Skip to content

Prevent high CPU usage by only running in astro projects #14704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Prevent high CPU usage by only running in astro projects #14704

wants to merge 1 commit into from
+18 −1

Conversation

@jp-knj
Copy link
Member

@jp-knj jp-knj commented Oct 31, 2025 •
edited
Loading

Changes

Closes #14641

  • Fix high CPU usage (110%) from VS Code extension on Apple Silicon
  • Add check to only run TypeScript plugin in Astro projects, returns empty plugins for non-Astro projects to save resources

Testing

  • To test the fix:
    • Open non-Astro project → CPU usage should be normal
    • Open Astro project → Extension should work as before

Docs

No docs needed. This fix only improves performance. Users don't need to change anything.

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2025

⚠️ No Changeset found

Latest commit: f4c8892

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jp-knj jp-knj self-assigned this Nov 1, 2025
@jp-knj jp-knj added the pr preview Apply this label to a PR to generate a preview release label Nov 1, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 1, 2025 

npm i https://pkg.pr.new/astro@14704

commit: f4c8892

@jp-knj
Copy link
Member Author

jp-knj commented Nov 1, 2025

@arunvisvajeetrs
Hi, Please install preview packages from the PR and test the fix 🙏🏿

@jp-knj jp-knj added the pkg: language-tools Related to language-tooling (scope) label Nov 1, 2025
Princesseuh
Princesseuh reviewed Nov 3, 2025
View reviewed changes
packages/language-tools/ts-plugin/src/index.ts
if (ts.sys.readDirectory) {
const hasAstroConfig =
ts.sys.readDirectory(
currentDir,
Copy link
Member

@Princesseuh Princesseuh Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest checking that this work inside monorepos!

@florian-lefebvre
Copy link
Member

florian-lefebvre commented Nov 4, 2025

Looks like the preview release is not made against the correct package. Could that be because changesets are not configured correctly?

@Princesseuh
Copy link
Member

Princesseuh commented Nov 4, 2025

Looks like the preview release is not made against the correct package. Could that be because changesets are not configured correctly?

the changesets should be fine (we've released these packages before from changesets), does pkg-pr-new needs config?

@florian-lefebvre
Copy link
Member

florian-lefebvre commented Nov 5, 2025

It shouldn't, we detect packages by calling changesets and pnpm: https://github.com/withastro/astro/blob/main/.github/workflows/preview-release.yml

@arunvisvajeetrs
Copy link

arunvisvajeetrs commented Nov 7, 2025

@arunvisvajeetrs Hi, Please install preview packages from the PR and test the fix 🙏🏿

Ok, I'll test it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Princesseuh Princesseuh Princesseuh left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@jp-knj jp-knj

Labels

pkg: language-tools Related to language-tooling (scope) pr preview Apply this label to a PR to generate a preview release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 BUG: High CPU usage from Astro Language Support extension on Apple Silicon

4 participants

@jp-knj @florian-lefebvre @Princesseuh @arunvisvajeetrs